This repository was archived by the owner on Jan 22, 2026. It is now read-only.
fix(deps): migrate validate-color to official npm package#379
Open
lewinpauli wants to merge 1 commit intooae:masterfrom
Open
fix(deps): migrate validate-color to official npm package#379lewinpauli wants to merge 1 commit intooae:masterfrom
lewinpauli wants to merge 1 commit intooae:masterfrom
Conversation
- Replace gitpkg.now.sh URL with npm registry version ^2.2.4 - Add named exports configuration in rollup for validate-color - Add custom rollup plugin to re-export named exports from bundled package docs: add GNOME session restart instructions to README
|
Ubuntu 25.10 x86_64 Gnome shell 49.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
couldnt start on fedora 43 gnome 49 branch master
The Bug
yarn install was not possible and created the following error:
after yarn install was fixed, Gnome Extension manager showed the following errors:
SyntaxError: The requested module 'file:///home/coco/.local/share/gnome-shell/extensions/pano@elhan.io/thirdparty/validate_color.js' doesn't provide an export named: 'validateHTMLColorHex' @ file:///home/coco/.local/share/gnome-shell/extensions/pano@elhan.io/extension.js:59:10The Fix
Migrate validate-color to official npm package
Problem
The validate-color dependency was using a custom GitHub package URL (https://gitpkg.now.sh/dreamyguy/validate-color/src/validate-color) which caused build issues with named exports not being properly re-exported during the rollup bundling process.
Changes Made
Updated validate-color dependency from gitpkg URL to official npm registry version ^2.2.4
Added namedExportsConfig object to explicitly define named exports for packages that need them:
validateHTMLColorName
validateHTMLColorSpecialName
validateHTMLColorHex
validateHTMLColorRgb
validateHTMLColorHsl
validateHTMLColorHwb
validateHTMLColorLab
validateHTMLColorLch
validateHTMLColor
Enhanced commonjs() plugin configuration with requireReturnsDefault: 'auto' and conditional defaultIsModuleExports
Added custom rollup plugin (export-named) to properly re-export named exports from bundled packages
yarn install && yarn build && pano works now
Fixes
#378
#281
Type of change
Please delete options that are not relevant.
Checklist