Conversation
|
@simong can you take a look at this |
There was a problem hiding this comment.
Is this no longer recommended?
There was a problem hiding this comment.
I think it's now recommended to have a SESSIONKEY.txt file
There was a problem hiding this comment.
When I had it in the settings.json I got this deprecation warning:
[2015-06-10 09:21:46.175] [WARN] console - Declaring the sessionKey in the settings.json is deprecated. This value is auto-generated now. Please remove the setting from the file.
|
The other changes LGTM, back to @stuartf fort the crowdin syncing |
|
Added crowdin sync script, it just pulls from crowdin currently (doesn't push existing translations back) |
|
Crowdin sync script now uploads keys and translations before downloading. Ready for review. |
There was a problem hiding this comment.
My preference would be to align this key synchronisation script a lot more with the 3akai-ux synchronisation script. I don't have a strong opinion about whether we use the crowdin JAR file or the node library, but I do think we should pick one that was use in both places to avoid having to maintain 2 completely different approaches. The 3akai-ux synchronisation script also does some things (e.g. removing empty translation files) which this should be doing.
@stuartf : What would be the best approach to aligning these more?
There was a problem hiding this comment.
This does remove the empty translation files.
I think the 3akai-ux sync script might be simplified by using the npm crowdin module, but there are differences in how the two projects handle translations so they can't just use the same script. I.E. 3akai-ux uses properties files and needs the manifest files updated with a list of translations, ep_oae uses json files and they all just live in the locales directory.
|
Finished review. I'll do a more detailed review once the synchronisation approaches have been aligned. Back to @stuartf |
|
I've removed the config file and made the apiKey get passed in on the command line. So, this is ready for more review. |
3 participants
No description provided.