Skip to content

fix: prevent DataAmount crash by guarding dataSize access #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul810050 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent DataAmount crash by guarding dataSize access #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions src/components/Dashboard/DataAmount.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<template>
<v-card outlined width="100%" height="100%" class="data-amount">
<div class="data-amount-container" v-if="dataSize">
<div class="data-amount-container" v-if="dataSize && dataSize.questions && dataSize.users !== undefined">
<div class="user-amount details">
<div class="icon-container">
<v-icon size="30" color="#2F80ED">{{ mdiAccount }}</v-icon>
</div>
<div class="amount-info">
<span class="amount">{{ dataSize.users }}</span>
<span class="amount">{{ usersAmount }}</span>
<span class="type">{{ $t('DASHBOARD.DATA_AMOUNT.users') }}</span>
</div>
</div>
Expand All @@ -17,7 +17,7 @@
}}</v-icon>
</div>
<div class="amount-info">
<span class="amount">{{ dataSize.questions.general }}</span>
<span class="amount">{{ questionsAmount }}</span>
<span class="type">{{ $t('TEST.QUIZ.questions') }}</span>
</div>
</div>
Expand All @@ -37,7 +37,7 @@
}}</v-icon>
</div>
<div class="amount-info">
<span class="amount">{{ dataSize.tests }}</span>
<span class="amount">{{ testsAmount }}</span>
<span class="type">{{ $t('TEST.QUIZ.quizzes') }}</span>
</div>
</div>
Expand Down Expand Up @@ -67,10 +67,35 @@ export default {
dataSize() {
return this.$store.getters.getDataSize;
},

usersAmount() {
return this.dataSize && typeof this.dataSize.users === "number"
? this.dataSize.users
: 0;
},

questionsAmount() {
return this.dataSize &&
this.dataSize.questions &&
typeof this.dataSize.questions.general === "number"
? this.dataSize.questions.general
: 0;
},

testsAmount() {
return this.dataSize && typeof this.dataSize.tests === "number"
? this.dataSize.tests
: 0;
},

subjectsAmount() {
return this.$store.state.Subject.subjects.length;
return this.$store.state.Subject &&
this.$store.state.Subject.subjects
? this.$store.state.Subject.subjects.length
: 0;
}
}

};
</script>

Expand Down