Fix Inbox render crash when question-requests size is null#22
Open
rahul810050 wants to merge 1 commit intooaiedu:masterfrom
Open
Fix Inbox render crash when question-requests size is null#22rahul810050 wants to merge 1 commit intooaiedu:masterfrom
rahul810050 wants to merge 1 commit intooaiedu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue: #21
PR summary
Inbox.vue was crashing during initial render because the
pageAmount computed property accessed
getDataSize["question-requests"] before Firestore data
was loaded.
This PR adds defensive guards in Inbox.vue pagination
logic, preventing render-time crashes and keeping
pagination stable for both admin and non-admin users.
there is another error from request.store.js file which is handled in this pr #12
Before:
After:
