improve fallback mechanism for source version matching#1450
improve fallback mechanism for source version matching#1450PeterMocary wants to merge 1 commit intooamg:mainfrom
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the leapp-repository contribution and development guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
PeterMocary
force-pushed
the
improve-unsupported-source-version-fallback
branch
from
758c81e to
277abe0
Compare
|
It will need some changes, due to the big changes that happened recently. |
When searching in the upgrade paths map by the system version, we had implemented a fallback that allowed the upgrade process to find a target version even if the minor version of the system did not match exactly with the ones defined in the map. The fallback mechanism was implemented using additional definitions in the map which did not have a minor version explicitly defined and thus would be only used as a fallback when the system version did not match any minor version. This patch changes this fallback mechanism to instead search in the map by the latest minor version of the system's major version. The additional records are removed from the map as well.
PeterMocary
force-pushed
the
improve-unsupported-source-version-fallback
branch
from
277abe0 to
87463a6
Compare
1 participant
This is the improvement change originating from PR#1443, @pirat89 wanted me to create this PR so we could discuss it again.
I did not try to run it after the big rebase yet.
When searching in the upgrade paths map by the system version, we had implemented a fallback that allowed the upgrade process to find a target version even if the minor version of the system did not match exactly with the ones defined in the map.
The fallback mechanism was implemented using additional definitions in the map which did not have a minor version explicitly defined and thus would be only used as a fallback when the system version did not match any minor version.
This patch changes this fallback mechanism to instead search in the map by the latest minor version of the system's major version. The additional records are removed from the map as well.