Skip to content

Comments

scan_target_os_iso: Make the actor distro agnostic #1483

Draft
matejmatuska wants to merge 1 commit intooamg:mainfrom
matejmatuska:distro-agnostic-isos
Draft

scan_target_os_iso: Make the actor distro agnostic #1483
matejmatuska wants to merge 1 commit intooamg:mainfrom
matejmatuska:distro-agnostic-isos

Conversation

@matejmatuska
Copy link
Member

@matejmatuska matejmatuska commented Jan 23, 2026 •
edited
Loading

This is just a patch I used for testing, needs polishing, unit testing and actual testing. It worked fine for the latest CS9 and CS10 ISOs.

This maybe also fixes using ISOs as source for conversions, haven't tried.

Leaving this here for the future.

Jira: RHEL-143786

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the leapp-repository contribution and development guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@matejmatuska
scan_target_os_iso: Make the actor distro agnostic
3da8809 
The determination of target version from the ISO does several checks
with hardcoded values such as the redhat-release packages name, the
filename and contents of /etc/redhat-release, as well as parsing the
actual version from there.

Most of these checks use hardcoded values which are only valid on RHEL.
This patch makes the checks work on CentOS Stream and Alma Linux by
obtaining the values from a map by distro.
@matejmatuska matejmatuska added the enhancement New feature or request label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@matejmatuska