This repository was archived by the owner on Apr 16, 2024. It is now read-only.
Open
Conversation
Co-authored-by: Wu Xueyang <45445803+wuxueyang96@users.noreply.github.com>
jikunshang
reviewed
Oct 25, 2023
cpp/src/types/PrestoToVeloxExpr.cpp
Outdated
| auto returnType = parseTypeSignature(pexpr.returnType); | ||
| if (getFunctionName(signature) == "presto.default.avg" || | ||
| getFunctionName(signature) == "presto.default.sum") { | ||
| VLOG(1) << "if"; |
cpp/src/types/PrestoToVeloxExpr.cpp
Outdated
| } else if (auto sqlFunctionHandle = | ||
| std::dynamic_pointer_cast<protocol::SqlFunctionHandle>( | ||
| pexpr.functionHandle)) { | ||
| VLOG(1) << "else"; |
Collaborator
Author
UT of agg node cannot pass currently.. It's relative to the issue mentioned above. According to the newest velox, functionHandle and arguments should be added in aggregations elements, I don't know which query @bigPYJ1151 ran to produce the JSON, maybe we should rerun it. |
Collaborator
I used TPCH Q1 and picked AggregationNode only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: still lead to error introduced by facebookincubator/velox#7018 and I've tried my best to deal with it but failed. @jikunshang
That will fail all aggregate functions, like
Maybe it comes with difference between Presto and Trino.