Add support for lists as dict values #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
array columns and auxiliary tables (for those DBs which don't support array columns), but it is only tested with postgres, which supports array columns. The aux table code is still untested.
rpiazza
merged commit 0d7862d
into
oasis-open:relational-data-sink
1 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other relational data source implementation attempts to support both array columns and auxiliary tables (for those DBs which don't support array columns), but this PR is only tested with postgres, which supports array columns. The aux table code is still untested.
This gets the test_datastore_relational_db.py unit test suite past the error I was seeing with test_email_msg(), when using postgres, at least.