Fix unit test cleanup bug in relational datastore test suite #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relational datastore test suite. Fixes a bug where proper unit test cleanup only happened if an exception occurred.
Merged
rpiazza
merged commit 0b8069c
into
oasis-open:fix-integer-constraint
1 of 6 checks passed
Contributor
|
The some rdb tests still fail not just the email one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes my goof where I used a try-except where I should have used a try-finally for a unit test cleanup. This caused some unit tests to not be properly cleaned up unless an exception occurred, which could cause subsequent unit test failures.