Skip to content

Conversation

@VigneshSubramania91
Copy link
Contributor

This is in reference to the PR #335.
The fix handles the update restrictions in addition to the changes proposed for insert restrictions with the above PR.

Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is merged, #316 must be adapted.

@VigneshSubramania91
Copy link
Contributor Author

@HeikoTheissen - I have removed the key and mandatory properties from required for update restrictions.
Could you please validate and merge if it looks okay.

@HeikoTheissen
Copy link
Contributor

You can merge, but when RAP starts supporting InsertRestrictions/RequiredProperties targeting EntitySet/NavigationProperty or in Capabilities.NavigationRestrictions, this change is no longer sufficient.

@HeikoTheissen
Copy link
Contributor

HeikoTheissen commented Aug 5, 2025

when RAP starts supporting InsertRestrictions/RequiredProperties targeting EntitySet/NavigationProperty or in Capabilities.NavigationRestrictions, this change is no longer sufficient.

RAP supports both patterns:

  • Target=EntitySet, Annotation=Capabilities.NavigationRestrictions/.../InsertRestrictions
  • Target=EntitySet/NavigationProperty, Annotation=Capabilities.InsertRestrictions

But not the combination of both:

  • Target=EntitySet/NavigationProperty, Annotation=Capabilities.NavigationRestrictions/.../InsertRestrictions

Currently, RAP does not add the RequiredProperties properties to either of these patterns, but this may come later: FIORITECHE1-9372

@VigneshSubramania91 VigneshSubramania91 merged commit 22c2a1e into oasis-tcs:main Nov 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants