feat(cmd/rofl): Add support for building TDX ROFL apps #298
Conversation
✅ Deploy Preview for oasisprotocol-cli ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kostko
force-pushed
the
kostko/feature/rofl-tdx
branch
8 times, most recently
from
e6e597e to
8bbcd58
Compare
kostko
force-pushed
the
kostko/feature/rofl-tdx
branch
from
8bbcd58 to
01e0f4e
Compare
kostko
force-pushed
the
kostko/feature/rofl-tdx
branch
3 times, most recently
from
9f90623 to
45d7161
Compare
|
This can now reproduce our measurements for up to 16 vCPUs on QEMU. |
|
It would be great if we could deterministically compile the ACPI tables, but my brief experiments with ASL did not help. So we are using per-CPU templates for now. |
kostko
force-pushed
the
kostko/feature/rofl-tdx
branch
7 times, most recently
from
b091590 to
daa5450
Compare
| return 0, err | ||
| } | ||
| fsSize /= 1024 // Convert to kilobytes. | ||
| fsSize = (fsSize * 150) / 100 // Scale by overhead factor of 1.5. |
There was a problem hiding this comment.
What is the typical size of the generated filesystems that you've tried so far?
Also, might be a good idea to add a check to make sure that fn is not an existing block device, so we don't accidentally trash a user's drive :)
(Currently, in the only place this function is called, the filename is hardcoded to rootfs.ext4, so it's not a problem, but it might be a problem in the future if we maybe have configurable filenames 🤷♂️)
kostko
force-pushed
the
kostko/feature/rofl-tdx
branch
from
daa5450 to
bda979f
Compare
kostko
force-pushed
the
kostko/feature/rofl-tdx
branch
2 times, most recently
from
ac69443 to
3e4ca2c
Compare
There was a problem hiding this comment.
Following the existing tutorial and running oasis rofl build tdx --mode unsafe compiled the ROFL, but when it tried to pack it, I got
[built] path+file:///home/oa/rofl-oracle#0.1.0
Preparing stage 2 root filesystem...
Unpacking template...
Adding runtime as init...
Creating ext4 filesystem...
Error: failed to create rootfs image: exit status 1
Do I need to install additional dependencies? No other errors seem to be reported.
|
Yes, let me add some checks whether the required tools exist. |
kostko
force-pushed
the
kostko/feature/rofl-tdx
branch
8 times, most recently
from
58fc579 to
362edf3
Compare
kostko
force-pushed
the
kostko/feature/rofl-tdx
branch
from
362edf3 to
e872c86
Compare
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
Nice! I can confirm that this actually produces a working tdx orc file.
No description provided.