feat(cmd/network): Autodetect chain context if none passed #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amela
force-pushed
the
amela/detect-chain-context
branch
3 times, most recently
from
61b21a5 to
da12da6
Compare
amela
force-pushed
the
amela/detect-chain-context
branch
2 times, most recently
from
a420941 to
420f953
Compare
amela
force-pushed
the
amela/detect-chain-context
branch
from
420f953 to
15d3ba6
Compare
matevz
reviewed
Nov 13, 2024
amela
force-pushed
the
amela/detect-chain-context
branch
2 times, most recently
from
b205788 to
9b79844
Compare
kostko
reviewed
Nov 14, 2024
Member
kostko
left a comment
kostko
left a comment
There was a problem hiding this comment.
Mostly looks good, one minor nit.
|
|
||
| "github.com/spf13/cobra" | ||
|
|
||
| "github.com/oasisprotocol/oasis-sdk/client-sdk/go/config" |
amela
force-pushed
the
amela/detect-chain-context
branch
from
9b79844 to
5e14044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.