Skip to content

fix(cmd/rofl): Refuse to overwrite app ID in create #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kostko merged 1 commit into from
Feb 12, 2025
Merged

fix(cmd/rofl): Refuse to overwrite app ID in create #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/rofl/mgmt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ var (
cobra.CheckErr("no ParaTime selected")
}

// In case an app ID is already assigned, refuse to overwrite.
if deployment != nil && deployment.AppID != "" {
cobra.CheckErr(fmt.Errorf("ROFL app identifier already defined (%s) for deployment '%s', refusing to overwrite", deployment.AppID, deploymentName))
}

// When not in offline mode, connect to the given network endpoint.
ctx := context.Background()
var conn connection.Connection
Expand Down Expand Up @@ -242,7 +247,7 @@ var (
return
}

fmt.Printf("Created ROFL application: %s\n", appID)
fmt.Printf("Created ROFL app: %s\n", appID)

if deployment != nil {
switch doUpdate {
Expand Down
Loading