cmd/statesync: Add command displaying recommended trust root #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
martintomazic
force-pushed
the
martin/feature/trust-height-command
branch
4 times, most recently
from
30aba83 to
24477ac
Compare
martintomazic
commented
Nov 3, 2025
Contributor
Author
|
Related to this, in general I have been very unlucky with state sync on the testnet, even after restarting the node multiple times. Might be a good idea to explore why this happening... |
peternose
reviewed
Nov 5, 2025
martintomazic
force-pushed
the
martin/feature/trust-height-command
branch
3 times, most recently
from
4b96e7d to
e12b8d5
Compare
peternose
approved these changes
Nov 6, 2025
martintomazic
force-pushed
the
martin/feature/trust-height-command
branch
from
e12b8d5 to
8653d04
Compare
peternose
reviewed
Nov 6, 2025
Prevents a problem where the most recent checkpoint target height is still being created on the remote nodes, but second oldest target height would be already older than the suggested trust. This is only relevant when configuring runtime where state is much bigger. In such case if you are connected to remote nodes that preserve many runtime state versions, checkpoint creation time is significant.
martintomazic
force-pushed
the
martin/feature/trust-height-command
branch
from
8653d04 to
74d5b57
Compare
peternose
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #558
Considerations:
#637 (comment)
How to test
Run
./oasis state-sync trust --network testnet|mainnetend ensure you are able to do state sync with returned parameters.