Skip to content

Update Box element#2258

Merged
kaja-osojnik merged 2 commits intomasterfrom
kaja/uil-box-various-3
Oct 21, 2025
Merged

Update Box element#2258
kaja-osojnik merged 2 commits intomasterfrom
kaja/uil-box-various-3

Conversation

@kaja-osojnik
Copy link
Contributor

Partial implementation of issue #2222.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Deployed to Cloudflare Pages

Latest commit: 1e1b78e5156ad3f3d3df6d5ef11e4e7917a0c172
Status:✅ Deploy successful!
Preview URL: https://b13e8e52.oasis-explorer.pages.dev
Alias: https://pr-2258.oasis-explorer.pages.dev

@kaja-osojnik kaja-osojnik marked this pull request as ready for review October 17, 2025 10:34
@kaja-osojnik kaja-osojnik self-assigned this Oct 17, 2025
@kaja-osojnik kaja-osojnik force-pushed the kaja/uil-box-various-3 branch 5 times, most recently from c90e5ea to 48e9cc2 Compare October 21, 2025 11:55
isMobile
? {
border:
theme.palette.background.default !== theme.palette.layout.border
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we are not migrating this comparison. not sure why we omit border for mainnet only. probably some old (blue theme) search related thing? #524

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donouwens any thoughts? I like it with the white border around on mobile to have a bit more space to breathe.

Branch:
Screenshot 2025-10-21 at 16 19 42

vs master:
Screenshot 2025-10-21 at 16 19 10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donouwens any thoughts? I like it with the white border around on mobile to have a bit more space to breathe.

-> Agreed @kaja-osojnik - we need it with the border and margin. It does not look good full width.

@kaja-osojnik kaja-osojnik force-pushed the kaja/uil-box-various-3 branch from 48e9cc2 to 1e1b78e Compare October 21, 2025 14:57
@kaja-osojnik kaja-osojnik merged commit c6c4a2a into master Oct 21, 2025
9 checks passed
@kaja-osojnik kaja-osojnik deleted the kaja/uil-box-various-3 branch October 21, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants