Skip to content

Fix outdated jsdoc types #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaw3d merged 2 commits into from
Oct 30, 2025
+3 −6
Merged

Fix outdated jsdoc types #2290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5149c
Fix outdated jsdoc types
lukaw3d Oct 30, 2025
1d42a09
Remove "keep it in sync" comment that is already ensured by types
lukaw3d Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/2290.trivial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix outdated jsdoc types
2 changes: 1 addition & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @ts-check

/** @type { import('eslint').Linter.Config } */
/** @type { import('eslint').Linter.LegacyConfig } */
const config = {
extends: [
'eslint:recommended', // https://eslint.org/docs/rules/
Expand Down
3 changes: 0 additions & 3 deletions src/app/components/ConsensusTransactionMethod/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,6 @@ const MethodIconWithTruncatedLabel: FC<MethodIconProps> = props => {
}

const getConsensusTransactionLabel = (t: TFunction, method: ConsensusTxMethod | undefined): string => {
// Please note: when updating this, keep it in sync
// with the knownConsensusTxMethods array below!

switch (method) {
case ConsensusTxMethod.stakingTransfer:
return t('transactions.method.stakingTransfer')
Expand Down
3 changes: 1 addition & 2 deletions vite.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import react from '@vitejs/plugin-react'
import tsconfigPaths from 'vite-tsconfig-paths'
import tailwindcss from '@tailwindcss/vite'

/** @type {import('vite').UserConfig} */
export default defineConfig(() => {
return {
plugins: [react(), tsconfigPaths(), tailwindcss()],
Expand All @@ -20,7 +19,7 @@ export default defineConfig(() => {
envPrefix: 'REACT_APP_',
css: {
modules: {
localsConvention: 'camelCase', // Optional: Ensures class names are imported as camelCase
localsConvention: /** @type {'camelCase'} */ ('camelCase'), // Optional: Ensures class names are imported as camelCase
},
},
}
Expand Down