-
Notifications
You must be signed in to change notification settings - Fork 12
MUI 'styled' cleanup #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
MUI 'styled' cleanup #2320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
3df8a2f to
1b8d09d
Compare
lukaw3d
requested changes
Nov 10, 2025
c61eeed to
f598fd2
Compare
f598fd2 to
1d8748d
Compare
lukaw3d
reviewed
Nov 13, 2025
src/app/components/Table/index.tsx
Outdated
Comment on lines
42
to
43
| className={cn(highlight && 'animate-[flash_3s_ease-in-out_1]')} | ||
| style={backgroundColor ? { backgroundColor } : highlight ? backgroundColorAnimation : undefined} |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
animate-[flash_3s_ease-in-out_1] and backgroundColorAnimation both do the same thing
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed backgroundColorAnimation
lukaw3d
approved these changes
Nov 13, 2025
1d8748d to
54a67b9
Compare
54a67b9 to
a18081f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert remaining styled MUI as a part of MUI to shadcn migration.
Leaving out instances on the homepage as its getting removed in PR #2302 and replaced with new design.
Closes #2316