Skip to content

Include module in error messages #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaw3d merged 3 commits into from
Dec 17, 2025
Merged

Include module in error messages #2394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8bb4bb
Include module in error messages
Aug 21, 2024
49b4c24
Revert "Don't show TX error messages for empty error blocks"
lukaw3d Dec 17, 2025
0a85703
Refactor
lukaw3d Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/2394.trivial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Include module in error messages
13 changes: 5 additions & 8 deletions src/app/hooks/useTxErrorMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,13 @@ import { TxError } from '../../oasis-nexus/api'

export const useTxErrorMessage = (error: TxError | undefined): string | undefined => {
const { t } = useTranslation()
if (
!error ||
(!error.module && !error.code) // TODO: This second check shouldn't be necessary. Remove when https://github.com/oasisprotocol/nexus/issues/704 is fixed.
)
if (!error) {
return undefined
}
if (error.module === 'evm' && error.code === 8 && !error.message && !error.raw_message) {
// EVM reverted, without any message
return `${t('errors.revertedWithoutMessage')} (${t('errors.code')} ${error.code})`
} else {
// Anything else
return `${error.message || error.raw_message} (${t('errors.code')} ${error.code})`
return `${t('errors.revertedWithoutMessage')} (${t('errors.code')} ${error.code}, ${t('errors.module')}: ${error.module})`
}

return `${error.message || error.raw_message} (${t('errors.code')} ${error.code}, ${t('errors.module')}: ${error.module})`
}
Loading