Conversation
cbc1db2 to
866c143
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors two SQL upsert queries to use an "update-first" pattern instead of standard INSERT ... ON CONFLICT syntax. The change prevents premature type validation failures when handling negative deltas for share values in PostgreSQL's custom uint_numeric type.
Key Changes:
- Replaced standard UPSERT with CTE-based update-first pattern for
RuntimeConsensusAccountDelegationUpsert - Applied the same pattern to
RuntimeConsensusAccountDebondingDelegationUpsert - Added explanatory comments describing why the pattern is necessary
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
866c143 to
48938e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
tested the fix with the exact same query that fails on mainnet db (with rollback of-course)
Future TODO: