Merged
Conversation
ptrus
force-pushed
the
ptrus/feature/stats-tx-volume
branch
from
22bcd53 to
1ba43c6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for querying transaction volume across all layers by introducing a new endpoint /v1/stats/tx_volume that aggregates tx_volume data from all layers, as opposed to the existing per-layer endpoint.
Key changes:
- Added new API endpoint
/stats/tx_volumethat returns aggregated transaction volume across all layers - Modified SQL queries to support NULL layer parameter for aggregating across all layers using SUM and GROUP BY
- Updated the
TxVolumesfunction signature to accept a nullable layer parameter
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| api/spec/v1.yaml | Added new /stats/tx_volume endpoint specification |
| api/v1/strict_server.go | Implemented handler for the new endpoint and updated existing handler to pass layer as pointer |
| storage/client/client.go | Modified TxVolumes function to accept nullable layer parameter |
| storage/client/queries/queries.go | Updated SQL queries to support NULL layer parameter with aggregation logic |
| tests/e2e_regression/common_test_cases.sh | Added test case for new endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ptrus
force-pushed
the
ptrus/feature/stats-tx-volume
branch
from
1ba43c6 to
8c065f5
Compare
ptrus
force-pushed
the
ptrus/feature/stats-tx-volume
branch
from
8c065f5 to
587e8a3
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1190