analyzer/evmverifier: Fix missing bytecode for verified contracts #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/bugfix/contracts-missing-bytecode
branch
from
f341f26 to
950d59a
Compare
Insert address preimages and queue verified contracts for bytecode analysis. Reprocess contracts missing preimages to backfill historical data from Sourcify.
ptrus
force-pushed
the
ptrus/bugfix/contracts-missing-bytecode
branch
from
950d59a to
46d4c82
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where verified smart contracts were missing their runtime bytecode in the database. The fix involves three main changes:
- Insert address preimages (ETH to Oasis address mappings) for all verified contracts
- Queue verified contracts for bytecode analysis to ensure bytecode gets fetched
- Reprocess contracts missing preimages to backfill historical data from Sourcify
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| storage/migrations/52_backfill_verified_contracts_bytecode.up.sql | Migration to backfill verified contracts into the bytecode analysis queue |
| analyzer/queries/queries.go | Updated queries to check for contracts missing preimages and improve bytecode analysis query |
| analyzer/evmverifier/evmverifier.go | Added logic to insert address preimages, queue contracts for bytecode analysis, and reprocess contracts missing preimages |
| tests/e2e_regression//e2e_config_.yml | Updated RPC endpoints and E2E regression artifacts version |
| tests/e2e_regression//expected/ | Updated expected test outputs to include address_preimage field |
| .changelog/1228.bugfix.md | Changelog entry for the fix |
| Makefile, .github/workflows/ci-test.yaml | Updated E2E regression artifacts version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1227
Insert address preimages and queue verified contracts for bytecode analysis. Reprocess contracts missing preimages to backfill historical data from Sourcify.