Conversation
ptrus
force-pushed
the
ptrus/feature/release-process
branch
3 times, most recently
from
8bc71f3 to
3ac064f
Compare
Andrew7234
reviewed
Dec 20, 2024
docs/release-process.md
Outdated
| - Create a new branch for the release: | ||
|
|
||
| ```bash | ||
| git push origin "${VERSION}" | ||
| ``` | ||
| ```bash | ||
| export VERSION=v0.0.1 | ||
| git checkout -b <user>/release-${VERSION} | ||
| ``` |
Contributor
There was a problem hiding this comment.
I think the ordering should be
- checkout a new release branch
git checkout -b <user>/release-${VERSION} - bump the
.punch_version.py make changelog
and then merge the PR, switch tomain, pull changes, andmake release-tagas described :)
Member
Author
There was a problem hiding this comment.
- checkout a new release branch git checkout -b /release-${VERSION}
Sure I'll reorder "switching branch" step and running make changelog. Although the order of these two steps does not matter.
- bump the .punch_version.py
make changelog bumps the .punch_version.py. So if you manually bump it before running make changelog the version will be increased twice:
Line 173 in 12a1ea7
ptrus
force-pushed
the
ptrus/feature/release-process
branch
from
3ac064f to
f51c772
Compare
ptrus
force-pushed
the
ptrus/feature/release-process
branch
from
f51c772 to
3038273
Compare
ptrus
force-pushed
the
ptrus/feature/release-process
branch
from
3038273 to
88f409c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #773