Skip to content

Split storage sync P2P protocol (manual fallback) #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martintomazic merged 5 commits into from
Aug 7, 2025

go/worker/storage/committee: Factor out checkpointer creation

c02ca0c
Select commit
Loading
Failed to load commit list.
Merged

Split storage sync P2P protocol (manual fallback) #6277

go/worker/storage/committee: Factor out checkpointer creation
c02ca0c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 7, 2025 in 0s

64.70% (+0.08%) compared to a81a9dd

View this Pull Request on Codecov

64.70% (+0.08%) compared to a81a9dd

Details

Codecov Report

❌ Patch coverage is 82.47012% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.70%. Comparing base (a81a9dd) to head (c02ca0c).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
go/worker/storage/committee/checkpoint_sync.go 72.88% 16 Missing ⚠️
go/worker/storage/p2p/checkpointsync/server.go 73.68% 6 Missing and 4 partials ⚠️
go/worker/storage/p2p/diffsync/server.go 73.33% 5 Missing and 3 partials ⚠️
go/worker/storage/committee/node.go 80.64% 5 Missing and 1 partial ⚠️
go/worker/storage/p2p/checkpointsync/client.go 95.45% 1 Missing and 1 partial ⚠️
go/worker/storage/p2p/diffsync/client.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6277      +/-   ##
==========================================
+ Coverage   64.62%   64.70%   +0.08%     
==========================================
  Files         690      696       +6     
  Lines       67593    67803     +210     
==========================================
+ Hits        43680    43870     +190     
- Misses      18855    18880      +25     
+ Partials     5058     5053       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov