go/worker/common: Replace epoch transitions with committee transitions #6425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
force-pushed
the
peternose/internal/committee-transition
branch
from
f272621 to
fdc2523
Compare
kostko
reviewed
Dec 4, 2025
|
|
||
| rs, err := n.Consensus.RootHash().GetRuntimeState(ctx, &roothash.RuntimeRequest{ | ||
| RuntimeID: n.Runtime.ID(), | ||
| Height: consensus.HeightLatest, |
Member
There was a problem hiding this comment.
Should this be synced by height instead of using "latest"?
Collaborator
Author
There was a problem hiding this comment.
Should this be synced by height instead of using "latest"?
We don't know at which height the committee was elected. Actually, all channels that we expose will never tell you on which height something happened, which is troublesome if you want to be in sync. Since the height is unknown, we can always use the latest. This is not a problem because:
- If the committee hasn't changed, things will work just fine.
- If the committee has changed, we will use a newer committee here, so scheduling will work with the latest committee. However, a new committee event will in that case arrive soon, which will invalidate everything and use again the latest committee. In this case all work (block scheduling) will probably be thrown away, but again, I don't see any problems.
Member
There was a problem hiding this comment.
all channels that we expose will never tell you on which height something happened
Except the annotated roothash blocks.
But sounds good, we should just make sure to test this well, maybe run some long-term tests.
kostko
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future there will be no empty
EpochTransitionruntime blocks, so we need to change the committee worker to be able to run without relying onHeaderTypeof runtime blocks.