Skip to content

go/common/node: Fix possible nil dereference #6463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martintomazic merged 2 commits into from
Feb 17, 2026
+16 −4
Merged

go/common/node: Fix possible nil dereference #6463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
258280f
go/common/node: Fix possible nil dereference
martintomazic Feb 16, 2026
47ac06b
go/common/node: Refactor ValidateBasic to happy path
martintomazic Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .changelog/6463.trivial.md
View file
Open in desktop
Empty file.
10 changes: 6 additions & 4 deletions go/common/node/sgx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,18 @@ func (sc *SGXConstraints) ValidateBasic(cfg *TEEFeatures, isFeatureVersion242 bo
return fmt.Errorf("unsupported SGX constraints version: %d", sc.V)
}

if sc.Policy == nil {
return nil
}

// Check for TDX enablement.
if !cfg.SGX.TDX && sc.Policy.PCS != nil && sc.Policy.PCS.TDX != nil {
return fmt.Errorf("TDX policy not supported")
}

// Check that policy is compliant with the current feature version.
if sc.Policy != nil {
if err := sc.Policy.Validate(isFeatureVersion242); err != nil {
return fmt.Errorf("invalid policy: %w", err)
}
if err := sc.Policy.Validate(isFeatureVersion242); err != nil {
return fmt.Errorf("invalid policy: %w", err)
}

return nil
Expand Down
10 changes: 10 additions & 0 deletions go/common/node/sgx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,16 @@ func TestSGXConstraintsV1(t *testing.T) {
require.NoError(err, "ValidateBasic V1 SGX constraints")
}

func TestSGXConstraintsV1NilPolicy(t *testing.T) {
require := require.New(t)

sc := SGXConstraints{
Versioned: cbor.NewVersioned(1),
}
err := sc.ValidateBasic(&TEEFeatures{SGX: TEEFeaturesSGX{PCS: true}}, true)
require.NoError(err, "ValidateBasic V1 SGX constraints with nil policy")
}

func TestSGXAttestationV0(t *testing.T) {
require := require.New(t)

Expand Down
Loading