Add Dockerfile for developing ROFL #2063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for oasisprotocol-oasis-sdk failed.
|
jberci
requested review from
kostko,
peternose,
pro-wh and
ptrus
as code owners
jberci
force-pushed
the
jberci/feature/macos-docker
branch
from
0cf620f to
0554b1b
Compare
matevz
reviewed
Nov 15, 2024
Member
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
I'll make another pass once Oasis CLI 0.10.3+ is released.
matevz
reviewed
Nov 15, 2024
lukaw3d
reviewed
Nov 15, 2024
| @@ -0,0 +1,9 @@ | |||
| FROM ghcr.io/oasisprotocol/oasis-core-dev:stable-24.3.x AS oasis-core-dev | |||
|
|
|||
| ARG OASIS_CLI_VERSION=0.10.3 | |||
lukaw3d
reviewed
Nov 15, 2024
jberci
force-pushed
the
jberci/feature/macos-docker
branch
2 times, most recently
from
dfe9879 to
5ffd4cd
Compare
jberci
force-pushed
the
jberci/feature/macos-docker
branch
from
5ffd4cd to
4e6fcc3
Compare
jberci
force-pushed
the
jberci/feature/macos-docker
branch
from
4e6fcc3 to
2f9396e
Compare
Contributor
|
I noticed I needed |
matevz
approved these changes
Dec 5, 2024
Member
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
Please address the issues. Otherwise lgtm. Merge oasisprotocol/docs#1042 first to unblock the CI.
jberci
force-pushed
the
jberci/feature/macos-docker
branch
from
2f9396e to
2b1a680
Compare
Since it now uses docusaurus extensions.
jberci
force-pushed
the
jberci/feature/macos-docker
branch
from
2b1a680 to
53b2d9d
Compare
kostko
approved these changes
Dec 20, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 20, 2024
…berci/feature/macos-docker Add Dockerfile for developing ROFL 6e253f9
github-actions bot
added a commit
that referenced
this pull request
Dec 20, 2024
…/jberci/feature/macos-docker Add Dockerfile for developing ROFL 6e253f9
github-actions bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Dec 20, 2024
…sisprotocol/jberci/feature/macos-docker Add Dockerfile for developing ROFL 6e253f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.