Skip to content

other: use slices.Contains to simplify code#742

Merged
ptrus merged 1 commit intooasisprotocol:mainfrom
rustrover:main
Jun 13, 2025
Merged

other: use slices.Contains to simplify code#742
ptrus merged 1 commit intooasisprotocol:mainfrom
rustrover:main

Conversation

@rustrover
Copy link
Copy Markdown
Contributor

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

@rustrover rustrover requested review from kostko and ptrus as code owners June 5, 2025 06:29
@rustrover rustrover force-pushed the main branch 4 times, most recently from 08a5ea5 to 56a44b4 Compare June 10, 2025 07:41
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (abcc957) to head (8925aa5).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
filters/event_system.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   60.96%   60.94%   -0.02%     
==========================================
  Files          40       40              
  Lines        4411     4404       -7     
==========================================
- Hits         2689     2684       -5     
+ Misses       1494     1492       -2     
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptrus
Copy link
Copy Markdown
Member

ptrus commented Jun 11, 2025

Looks good thanks! Please rebase on master and its good to merge!

Signed-off-by: rustrover <seekseat@126.com>
@rustrover
Copy link
Copy Markdown
Contributor Author

Looks good thanks! Please rebase on master and its good to merge!

Done. Please review again.

@ptrus ptrus merged commit 7afe9ed into oasisprotocol:main Jun 13, 2025
5 of 8 checks passed
@ptrus
Copy link
Copy Markdown
Member

ptrus commented Jun 13, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants