feat: use the built-in max/min to simplify the code#755
Merged
ptrus merged 1 commit intooasisprotocol:mainfrom Jul 29, 2025
Merged
feat: use the built-in max/min to simplify the code#755ptrus merged 1 commit intooasisprotocol:mainfrom
ptrus merged 1 commit intooasisprotocol:mainfrom
Conversation
Member
|
Thanks, looks good. Please just update the commit message to match the guidelines. e.g. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
+ Coverage 60.94% 61.02% +0.08%
==========================================
Files 40 40
Lines 4404 4416 +12
==========================================
+ Hits 2684 2695 +11
Misses 1492 1492
- Partials 228 229 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Thank you for your guidance; I have made the fixes. Please review again. |
Signed-off-by: pingshuijie <pingshuijie@outlook.com>
ptrus
approved these changes
Jul 29, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.