Skip to content

fix: Fix parsing of legacy transactions without chain ID #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptrus merged 1 commit into from
Jul 31, 2025
Merged

fix: Fix parsing of legacy transactions without chain ID #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion indexer/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,14 @@ func blockToModels(
for idx, ethTx := range transactions {
ethTxHex := ethTx.Hash().Hex()
v, r, s := ethTx.RawSignatureValues()
signer := ethtypes.LatestSignerForChainID(ethTx.ChainId())
chainID := ethTx.ChainId()
if chainID != nil && chainID.Cmp(big.NewInt(0)) == 0 {
// Legacy transactions don't have a chain ID but `ChainId()` returns 0, which is invalid
// for `LatestSignerForChainId` which expects a null in that case (zero causes a panic).
// https://github.com/ethereum/go-ethereum/issues/31653
chainID = nil
}
signer := ethtypes.LatestSignerForChainID(chainID)
from, _ := signer.Sender(ethTx)
ethAccList := ethTx.AccessList()
accList := make([]model.AccessTuple, 0, len(ethAccList))
Expand Down
Loading