rofl: Split stdout and stderr for CLI commands#85
Merged
Conversation
f42be0b to
5452fdc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR separates stdout and stderr output streams for CLI commands instead of combining them into a single logs field. The change improves observability by allowing consumers to distinguish between standard output and error output from command executions.
- Split the single
Logsfield into separateStdoutandStderrfields in command result structures - Update all references to use the new separate fields in logging statements and result processing
- Modify command execution to capture stdout and stderr separately instead of combining them
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| worker/oasiscli/oasiscli.go | Updated command execution to capture stdout/stderr separately and modified result structure |
| worker/worker.go | Updated all log statements and result assignments to use separate stdout/stderr fields |
| tasks/roflbuild.go | Changed result structure to include separate stdout/stderr fields instead of logs |
| tasks/roflvalidate.go | Changed result structure to include separate stdout/stderr fields instead of logs |
| e2e/e2e_test.go | Updated test assertions to check stdout/stderr fields instead of logs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84