Skip to content

rofl: Split stdout and stderr for CLI commands#85

Merged
ptrus merged 1 commit intomasterfrom
ptrus/feature/rofl-cli-split-stdout
Sep 3, 2025
Merged

rofl: Split stdout and stderr for CLI commands#85
ptrus merged 1 commit intomasterfrom
ptrus/feature/rofl-cli-split-stdout

Conversation

@ptrus
Copy link
Member

@ptrus ptrus commented Sep 3, 2025

Fixes #84

@ptrus ptrus force-pushed the ptrus/feature/rofl-cli-split-stdout branch from f42be0b to 5452fdc Compare September 3, 2025 12:42
@ptrus ptrus requested a review from Copilot September 3, 2025 12:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates stdout and stderr output streams for CLI commands instead of combining them into a single logs field. The change improves observability by allowing consumers to distinguish between standard output and error output from command executions.

  • Split the single Logs field into separate Stdout and Stderr fields in command result structures
  • Update all references to use the new separate fields in logging statements and result processing
  • Modify command execution to capture stdout and stderr separately instead of combining them

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
worker/oasiscli/oasiscli.go Updated command execution to capture stdout/stderr separately and modified result structure
worker/worker.go Updated all log statements and result assignments to use separate stdout/stderr fields
tasks/roflbuild.go Changed result structure to include separate stdout/stderr fields instead of logs
tasks/roflvalidate.go Changed result structure to include separate stdout/stderr fields instead of logs
e2e/e2e_test.go Updated test assertions to check stdout/stderr fields instead of logs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ptrus ptrus merged commit 23339ac into master Sep 3, 2025
7 checks passed
@ptrus ptrus deleted the ptrus/feature/rofl-cli-split-stdout branch September 3, 2025 13:04
ptrus added a commit that referenced this pull request Sep 8, 2025
ptrus added a commit that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split stderr and stdout in rofl command responses

2 participants