Conversation
lukaw3d
reviewed
Jan 14, 2025
| window.mock = false | ||
|
|
||
| export const amountPattern = '^[0-9]*[.]?[0-9]{0,9}$' | ||
| export const withdrawEstimatedFee = parseUnits('0.007', 18) |
Contributor
There was a problem hiding this comment.
This is a duplicate of withdrawFeeAmount
lukaw3d
reviewed
Jan 14, 2025
| try { | ||
| const amount = parseUnits(_value, consensusConfig.decimals) | ||
|
|
||
| if (amount * 10n ** 9n < withdrawEstimatedFee) { |
Contributor
There was a problem hiding this comment.
This allows values that are too low, and the transaction fails (move app doesn't detect the failure). It should be checking at least minimalWithdrawableAmount, but I only verified as low as 0.1; that's why I was using <input name="amount" type="number" step="any" min="0.1" required />
(related #87)
lukaw3d
reviewed
Feb 18, 2025
Comment on lines
+93
to
+95
| // Loop unless in input mode, case when user click transfer more | ||
| if (!isInputMode) { | ||
| await step4(consensusAddress) |
Contributor
There was a problem hiding this comment.
Somehow this still often loops and then causes race conditions. Not sure if due to later changes like 61504fc
Related #155 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current flow changes were introduced:
Resolves #94
Resources
https://www.loom.com/share/a3669d9c19504c4b89547ceb906b5bc8?sid=0856742a-8ab8-4eaf-a32a-c1c227045c14