Skip to content

Conversation

@csillag
Copy link
Collaborator

@csillag csillag commented Sep 30, 2025

(This PR is implemented on top of #100 and #101, so only the last few commits belong to this change.)

<Input
    placeholder="Search..."
    beforeStartDecoration={<SettingsIcon className="h-4 w-4 text-muted-foreground" />}
    startDecoration={<SettingsIcon className="h-4 w-4" />}
    endDecoration={<LaunchIcon className="h-4 w-4" />}
    afterEndDecoration={<LaunchIcon className="h-4 w-4 text-muted-foreground" />}
/>

Now gets us:

image

(We can adjust the exact style for the separator when we have agreement on the working of the code.)

This is required for the designs like this:

image

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Deployed to Cloudflare Pages

Latest commit: d7341cc9d3c930aaef8342e5e0b372db8d21855c
Status:✅ Deploy successful!
Preview URL: https://1f77c846.oasis-ui.pages.dev
Alias: https://pr-72.oasis-ui.pages.dev

@csillag csillag force-pushed the csillag/input-decorations branch from a549d6a to 1b0bd77 Compare September 30, 2025 19:35
@csillag csillag force-pushed the csillag/input-decorations branch from 1b0bd77 to 2530858 Compare November 3, 2025 06:24
@csillag csillag force-pushed the csillag/input-decorations branch from 2530858 to 99c0df7 Compare January 14, 2026 10:58
There used to be a warning:

> ▲ [WARNING] The "assert" keyword is not supported
> in the configured target environment
> ("node22.21.1") [assert-to-with]

This changes fixes that.
@csillag csillag force-pushed the csillag/input-decorations branch from 99c0df7 to 806dbb0 Compare January 14, 2026 11:01
@csillag csillag marked this pull request as ready for review January 14, 2026 11:01
@csillag csillag marked this pull request as draft January 14, 2026 11:16
External decorations are separated using an extra line
@csillag csillag force-pushed the csillag/input-decorations branch from 39db876 to d7341cc Compare January 14, 2026 11:19
@lubej
Copy link
Collaborator

lubej commented Jan 15, 2026

Rebase after #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants