Merge pull request #284 from jkroepke/enableServiceLinks

Make deploy.enableServiceLinks configurable

Author: pierluigilenoci

helm/oauth2-proxy/Chart.yaml

@@ -1,5 +1,5 @@
 name: oauth2-proxy
-version: 7.10.5
+version: 7.11.0
 apiVersion: v2
 appVersion: 7.8.1
 home: https://oauth2-proxy.github.io/oauth2-proxy/
@@ -32,7 +32,7 @@ kubeVersion: ">=1.16.0-0"
 annotations:
   artifacthub.io/changes: |
     - kind: added
-      description: Add documentation to ensure Redis password consistency between sessionStorage and Redis sub chart is well explained
+      description: Make deploy.enableServiceLinks configurable
       links:
         - name: Github PR
-          url: https://github.com/oauth2-proxy/manifests/pull/283
+          url: https://github.com/oauth2-proxy/manifests/pull/284

helm/oauth2-proxy/README.md

@@ -136,6 +136,7 @@ The following table lists the configurable parameters of the oauth2-proxy chart
 | `config.google.existingConfig`                        | existing Kubernetes configmap to use for the service account file. See [Google secret template](https://github.com/oauth2-proxy/manifests/blob/master/helm/oauth2-proxy/templates/google-secret.yaml) for the required values                                    | `nil`                                                                            |
 | `config.google.groups`                                | restrict logins to members of these Google groups                                                                                                                                                                                                                | `[]`                                                                             |
 | `containerPort`                                       | used to customize port on the deployment                                                                                                                                                                                                                         | `""`                                                                             |
+| `enableServiceLinks`                                  | configure deployment enableServiceLinks                                                                                                                                                                                                                                    | `true`                                                                           |
 | `extraArgs`                                           | Extra arguments to give the binary. Either as a map with key:value pairs or as a list type, which allows the same flag to be configured multiple times. (e.g. `["--allowed-role=CLIENT_ID:CLIENT_ROLE_NAME_A", "--allowed-role=CLIENT_ID:CLIENT_ROLE_NAME_B"]`). | `{}` or `[]`                                                                     |
 | `extraContainers`                                     | List of extra containers to be added to the pod                                                                                                                                                                                                                  | `[]`                                                                             |
 | `extraEnv`                                            | key:value list of extra environment variables to give the binary                                                                                                                                                                                                 | `[]`                                                                             |

helm/oauth2-proxy/templates/deployment.yaml

@@ -58,6 +58,7 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
       serviceAccountName: {{ template "oauth2-proxy.serviceAccountName" . }}
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }}
       {{- if .Values.hostAliases }}
       hostAliases:

helm/oauth2-proxy/values.yaml

@@ -284,6 +284,7 @@ podLabels: {}
 replicaCount: 1
 revisionHistoryLimit: 10
 strategy: {}
+enableServiceLinks: true
 
 ## PodDisruptionBudget settings
 ## ref: https://kubernetes.io/docs/concepts/workloads/pods/disruptions/