Skip to content

fix: recommended setting for redis when using 1 replica #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: recommended setting for redis when using 1 replica #359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
742e294
fix: fix recommended setting for redis
nleconte-csgroup Sep 30, 2025
5ea0734
Merge branch 'main' into patch-1
pierluigilenoci Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions helm/oauth2-proxy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,9 @@ redis:
#
Copy link
Member

@tuunit tuunit Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take the opportunity and change this section a bit more. Instead of having a single node cluster setup as the recommendation. We should reference the example files directory here. What do you think?

Copy link
Member

@tuunit tuunit Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierluigilenoci whats your stance on this?

Copy link
Contributor

@pierluigilenoci pierluigilenoci Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything that improves the readability or usefulness of the value file is welcome.

# redisPassword: xxxxx
# replicas: 1
# redis:
# config:
# min-replicas-to-write: 0
# persistentVolume:
# enabled: false
#
Expand Down