Merged
Conversation
…gistry type support for cache and normal registries This commit introduces a new 'type' field in the config.sample.yaml to distinguish between caching and normal registries. It modifies functions.py to handle this new type by configuring or removing the proxy accordingly. The generate.py script is updated to set a default type of 'cache' if not specified and to ensure proper handling of the password field. Additionally, setup.py is enhanced to prompt users for adding a private registry with type 'registry'.
This commit adds default values to the prompts for entering registry details in setup.py. The defaults are "docker" for the registry name, "https://registry-1.docker.io" for the registry URL, and "720h" for the TTL. Additionally, a default value of "private" is added for the private registry name prompt.
This commit adds comments throughout the setup.py script to enhance code readability and understandability. The comments cover module imports, YAML parser configuration, user prompts, registry configuration, storage options, and final steps instructions. These annotations will help other developers comprehend the flow and purpose of each section within the script.
Expanded README with a new 'Features' section, highlighting the guide's capabilities, including support for private registries and Docker/Kubernetes compatibility. Enhanced instructions to cover advanced configurations related to private registries. Updated keywords for better context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the possibility to have private registry