Skip to content

Commit ccb7144

Browse files
committed
2024-10-16 - Create assignments upon creation of review-object, and make it so the "findAll" will not return all members if member-list is empty
1 parent 508486c commit ccb7144

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

server/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewAssignmentServicesImpl.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,6 @@ public Set<ReviewAssignment> findAllByReviewPeriodIdAndReviewerId(UUID reviewPer
8282
} else {
8383
reviewAssignments = reviewAssignmentRepository.findByReviewPeriodIdAndReviewerId(reviewPeriodId, reviewerId);
8484
}
85-
if (reviewAssignments.isEmpty()) {
86-
//If no assignments exist for the review period, then a set of default review assignments should be returned
87-
reviewAssignments = defaultReviewAssignments(reviewPeriodId);
88-
}
8985

9086
return reviewAssignments;
9187
}

0 commit comments

Comments
 (0)