feat(#199): Optimize empty-object.xsl Check#210
Merged
yegor256 merged 7 commits intoobjectionary:masterfrom Jan 9, 2025
Merged
feat(#199): Optimize empty-object.xsl Check#210yegor256 merged 7 commits intoobjectionary:masterfrom
empty-object.xsl Check#210yegor256 merged 7 commits intoobjectionary:masterfrom
Conversation
Member
Author
|
@yegor256 Could you review these changes, please? |
This was referenced Jan 9, 2025
Member
|
@volodya-lombrozo awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have written the test that identifies the problem with
empty-objectscheck. Actually, it’s not a problem with the check. It’s a problem withjcabi-xmilibrary. I’ve optimised some parts ofLtByXsland added several puzzles to return the previous code back when these parts will be fixed.Timings (for the new added test:)
Related to #199.