bug(#208): incorrect-package accepts fqn#211
Conversation
|
waiting for #213 |
|
@volodya-lombrozo could you check this one, please? |
|
@h1alexbel this is full regexp for FQN in EO: https://github.com/objectionary/eo/blob/master/eo-parser/src/main/resources/XMIR.xsd#L99 Maybe it's better to fix our matcher once and for all, not only for the Will our current lint pass it? |
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@h1alexbel Despite having lowercase letters and _, $ signs, Java package might contain uppercase letters:
The specification allows it [uppercase characters] just fine. It's only a convention to use all-lower-case.
$fqn
|
@volodya-lombrozo updated. Take a look, please |
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@h1alexbel Looks good to me, thank you!
|
@yegor256 take a look, please |
|
@h1alexbel thanks! |
In this pull I've updated
incorrect-packagelint to support FQN names.see #208