bug(#209): better defect message in mandatory-home#214
bug(#209): better defect message in mandatory-home#214yegor256 merged 6 commits intoobjectionary:masterfrom
Conversation
|
waiting for #213 |
|
@volodya-lombrozo could you please check this one? |
There was a problem hiding this comment.
@h1alexbel Thank you for the contribution! It's a bit more clear now, but for me it's not sufficient because I don't know what to do with the url and home meta.
Should it be <home url="x"/> or <meta><home><url>x</url></home></meta> or <meta home="x"/>? It's impossible to say from this message.
@yegor256 Can you help us with this, please? Can we add a link to the description or at least something.
|
@volodya-lombrozo we can't explain in one error message how XMIR format is designed. It's expected that the user has certain background knowledge about XMIR and knows what is "meta". We can add information about XMIR into the Javadoc of the |
@yegor256 Maybe we can add a single link to the documentation of XMIR where I will be able to find information about It will look like: Otherwise, this PR doesn't solve the original issue. |
|
@volodya-lombrozo @yegor256 I think publishing (but not linking actually) our lint motives will help with the understanding what needs to be fixed: So the user will find the rule id, let's say: Currently we have them here: https://github.com/objectionary/lints/tree/gh-pages/_site/0.0.31, but their are not accessible through website. WDYT? |
|
@volodya-lombrozo I believe, the links are added in this PR: #229 |
|
@h1alexbel this contribution is good, thanks! |
|
@volodya-lombrozo as a general rule, a merge PR doesn't mean a closed issue. When PR is good enough to be merged, we should accept it and merge ASAP. Then, we get back to the ticket and discuss whether it may be closed. If not, we make another PR, and so on. "This PR doesn't solve the problem" is not a valid reason for its rejection. |
In this pull I've updated defect message reported by
mandatory-homelint, now it says about the need of home URL.see: #209