Skip to content

bug(#227): incorrect-alias scans second part of longer +alias#235

Merged
rultor merged 3 commits intoobjectionary:masterfrom
h1alexbel:227
Jan 14, 2025
Merged

bug(#227): incorrect-alias scans second part of longer +alias#235
rultor merged 3 commits intoobjectionary:masterfrom
h1alexbel:227

Conversation

@h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented Jan 13, 2025

In this PR I've updated incorrect-alias lint to scan the second part of +alias meta, if it has the second part inside.

Example:

+alias stdout org.eolang.io.stdout

In this case, org/eolang/io/stdout.xmir will be scanned.

see #227
History:

@h1alexbel
Copy link
Member Author

@yegor256 take a look, please

@yegor256
Copy link
Member

@maxonfjvipon please, check this one

@yegor256 yegor256 requested a review from maxonfjvipon January 13, 2025 18:40
@h1alexbel
Copy link
Member Author

h1alexbel commented Jan 14, 2025

@yegor256 please check

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jan 14, 2025

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 03ce6d0 into objectionary:master Jan 14, 2025
13 checks passed
@yegor256
Copy link
Member

@h1alexbel thanks!

@rultor
Copy link
Contributor

rultor commented Jan 14, 2025

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min).

@h1alexbel h1alexbel deleted the 227 branch January 14, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants