bug(#268): allow vertical-bound-method in application-duality#280
Merged
yegor256 merged 5 commits intoobjectionary:masterfrom Jan 28, 2025
Merged
bug(#268): allow vertical-bound-method in application-duality#280yegor256 merged 5 commits intoobjectionary:masterfrom
application-duality#280yegor256 merged 5 commits intoobjectionary:masterfrom
Conversation
application-duality
Member
Author
|
@maxonfjvipon please check this one. I'm not sure if my fix is right. Would like to hear your feedback |
maxonfjvipon
suggested changes
Jan 28, 2025
| <xsl:if test="count(o) != count(o[@as]) and count(o) != count(o[not(@as)])"> | ||
| <xsl:variable name="violates" as="xs:boolean"> | ||
| <xsl:choose> | ||
| <xsl:when test="starts-with(@base, '.')"> |
Member
There was a problem hiding this comment.
@h1alexbel let's simplify all of this with something like:
<xsl:variable name="args">
<xsl:choose>
<xsl:when test="starts-with(@base, '.')">
<xsl:value-of select="o[position()>1]"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="o"/>
</xsl:otherwise>
</xsl:choose>
</xsl:variable>
<xsl:if test="count($args) != count($args[@as]) and count($args) != count($args[not(@as)])"/>
Member
Author
|
@maxonfjvipon updated. Take a look, please |
maxonfjvipon
approved these changes
Jan 28, 2025
Member
Author
|
@yegor256 take a look, please |
Member
|
@h1alexbel thanks! |
|
@maxonfjvipon Thanks for the review! Here's your reward breakdown: +4 base points, -24 for self-review, +1.6 for 160 hits-of-code, -10 for only 5 comments, +1.25 for those comments. Total: 4 points (min. reward). Your balance is now +27. Keep up the good work and aim for more comments next time! 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I've updated
application-dualitylint to handle@asreferences in vertical and horizontal method bounds.see #268
History:
application-dualityfalse alarm #268): skip firstapplication-dualityfalse alarm #268): count(as) not 0