-
Notifications
You must be signed in to change notification settings - Fork 17
feat(#108): @ must be at top level
#587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
|
| # Comment. | ||
| [] > app | ||
| foo > x | ||
| bar > @ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marat-Tim maybe just this:
[] > app
foo > x
bar > @
This will better illustrate what you expect users to write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yegor256 I don't get it - the example here is Incorrect, but the code you're suggesting doesn't actually violate rules of this lint
|
@h1alexbel please, review this one |
I'm not sure we can rely on the order of objects within a single tag, or that using
@in inner objects will always result in an element withbase='$.@'But if that’s not guaranteed, it seems like implementing this lint may not be possible