Fix CI failures: export StackSchema, add chart-bar color default, remove unused param #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…emove unused param Co-authored-by: hotlong <[email protected]>
Copilot
AI
changed the title
[WIP] Fix action job issue in CI pipeline
Fix CI failures: export StackSchema, add chart-bar color default, remove unused param
Jan 17, 2026
hotlong
approved these changes
Jan 17, 2026
github-actions
bot
added
package: types
package: components
plugin
plugin: charts
labels
hotlong
merged commit eed8fa9
into
copilot/add-showcase-trial-documentation
8 of 9 checks passed
|
✅ All checks passed!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses CI build failures caused by TypeScript compilation errors and a failing test. The changes are targeted fixes to resolve import errors, missing type exports, a test assertion failure, and unused parameter warnings.
Changes:
- Exported
StackSchemafrom the types package to fix import error in stack component renderer - Added
color: '#8884d8'default to chart-bar component registration to satisfy test expectations - Removed unused
isChildparameter from TreeNodeComponent to eliminate TypeScript warning
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/types/src/index.ts | Added StackSchema to public type exports to fix import error in stack.tsx |
| packages/types/src/layout.ts | Added StackSchema to LayoutSchema union type for completeness |
| packages/plugin-charts/src/index.tsx | Added missing color default property to fix failing test assertion |
| packages/components/src/renderers/data-display/tree-view.tsx | Removed unused isChild parameter and its usage to eliminate TS6133 warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI build failing with TypeScript errors and test failure in workflow run #21089060389.
Changes:
Export
StackSchematype — Added to@object-ui/typespublic API andLayoutSchemaunion. The type was defined but not exported, breaking imports inpackages/components/src/renderers/layout/stack.tsx.Add
color: '#8884d8'tochart-bardefaultProps — Test expected this default but it was missing from the component registration.Remove unused
isChildparameter —TreeNodeComponentdeclared but never read the parameter, causing TS6133 warning.Diff summary:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.