Skip to content

fix: replaces UNSAFE_componentWillReceiveProps with componentDidUpdate #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replaces UNSAFE_componentWillReceiveProps with componentDidUpdate #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions createAnimatableComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,7 @@ export default function createAnimatableComponent(WrappedComponent) {
}
}

// eslint-disable-next-line camelcase
UNSAFE_componentWillReceiveProps(props) {
componentDidUpdate(previousProps) {
const {
animation,
delay,
Expand All @@ -327,12 +326,12 @@ export default function createAnimatableComponent(WrappedComponent) {
iterationDelay,
transition,
onAnimationBegin,
} = props;
} = this.props;

if (transition) {
const values = getStyleValues(transition, props.style);
const values = getStyleValues(transition, this.props.style);
this.transitionTo(values, duration, easing, delay);
} else if (!deepEquals(animation, this.props.animation)) {
} else if (!deepEquals(animation, previousProps.animation)) {
if (animation) {
if (this.delayTimer) {
this.setAnimation(animation);
Expand Down Expand Up @@ -418,7 +417,7 @@ export default function createAnimatableComponent(WrappedComponent) {
: iterationCount <= 1,
duration: duration || this.props.duration || 1000,
useNativeDriver,
delay: (iterationDelay && currentIteration > 0) ? iterationDelay : 0,
delay: iterationDelay && currentIteration > 0 ? iterationDelay : 0,
Copy link
Author

@GuillaumeOj GuillaumeOj May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change made with yarn format

};

Animated.timing(animationValue, config).start((endState) => {
Expand Down