-
-
Notifications
You must be signed in to change notification settings - Fork 532
test: refactor e2e tests to use helper for checking status message #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@DorianMazur hopefully this is less flakey . Writing up the PR description when I get back to my laptop |
Contributor
Author
|
Will do the same for all statues |
…mproved clarity and consistency
Contributor
Author
|
ah doesnt work on ios |
- due to `ResetDevice` properly resetting our tests
Contributor
Author
|
@DorianMazur I think I may have got them stable |
Contributor
Author
|
streamline wait times in authHelpers this test failed because of unsure what caused it though |
This was referenced Mar 26, 2025
Contributor
Author
|
@DorianMazur lmk what you think :) |
Collaborator
|
@Bowlerr I will check this PR and others in next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the E2E tests to improve the handling and assertion of credential status messages by:
new helper functions for:
expectCredentialsLoadedMessageexpectCredentialsSavedMessageexpectCredentialsResetMessageRefactor test with new helpers.
added new helper for
expectRegexTextthat uses another new helperretryto try mitigate the tests being flakey even though screenshots are showing they have passed.These changes aim to improve maintainability and consistency of the tests.