Merged
Conversation
This bug was never seen as only one Command is ever constructed per-run, but for posterity we ensure that each Command instance has it's own help string storage so that if for whatever reason in the future we make multiple commands at once, the help string is not stuck as the one created for the first command used. In the long, once possible, the help string should be a constexpr member that is made at compile time. We could do that now if using std::string, but it's not a big deal.
This way we don't need to pass them again when processing the command.
This allows bailing earlier if there is no need to proceed, for example if help for a command was requested.
Adds a full screen parameter to the title's underlying executable automatically if available and known. Only Ruffle is currently supported.
Add general 'fullscreen' switch to CPlay
github-actions
bot
added
the
release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.