Conversation
97b5ed5 to
bc71a86
Compare
Contributor
|
Why not implement it directly to |
Owner
Author
|
I tried that and it had some downsides:
|
6a5cdfe to
51ddab8
Compare
✅ Deploy Preview for cynic-querygen-web canceled.
|
Contributor
|
Understand. I'm still really surprised you even took the effort. This would work well with some derive persistence system for query-gen, where you can add additional derives to the generated structs. That would be awesome. I'm sure more people could use this. |
Contributor
|
Btw why not use generics instead of dyn? |
Owner
Author
|
Using generics would have meant one of:
Whereas dynamic dispatch avoids most of these downsides, and doesn't introduce many I can think of. |
Contributor
|
Makes sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
Cynic now supports inlining variables as a first class feature.
What effects does this change have?
Adds an example and documentation for this feature
TODO:
QueryBuilderetc. #1008 is merged avoid using OperationBuilder directly in this