Skip to content

fix: disable warnings in CI #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obmarg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: disable warnings in CI #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ on:
branches: [main]

env:
COLUMNS: 250
COLUMNS: 80
CARGO_INCREMENTAL: 0
# TODO: Would be nice to disable warnings here too, but there are too many of them.
RUSTFLAGS: "-W rust-2021-compatibility"
RUSTFLAGS: "-W rust-2021-compatibility -D warnings"
RUST_BACKTRACE: short
NEXTEST_PROFILE: ci
CI: 1
Expand Down
1 change: 1 addition & 0 deletions tests/ui-tests/tests/cases/enum-guess-validation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ mod schema {
schema_path = "../../../../schemas/simple.graphql",
graphql_type = "Desseqt"
)]
#[allow(non_camel_case_types)]
enum Dessert {
CHEESECAKE,
ICE_CREAM,
Expand Down
8 changes: 0 additions & 8 deletions tests/ui-tests/tests/cases/enum-guess-validation.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,3 @@ error: Could not find a type named `Desseqt` in the schema
|
10 | graphql_type = "Desseqt"
| ^^^^^^^^^

warning: variant `ICE_CREAM` should have an upper camel case name
--> tests/cases/enum-guess-validation.rs:14:5
|
14 | ICE_CREAM,
| ^^^^^^^^^ help: convert the identifier to upper camel case: `IceCream`
|
= note: `#[warn(non_camel_case_types)]` on by default
Loading