feat: infer bounds for generic nested query fragments#893
Open
feat: infer bounds for generic nested query fragments#893
Conversation
✅ Deploy Preview for cynic-querygen-web canceled.
|
obmarg
force-pushed
the
obmarg/push-tutrxopnrnvl
branch
3 times, most recently
from
4713ea6 to
37d48b9
Compare
Owner
Author
|
I should probably update the book for these changes |
obmarg
force-pushed
the
obmarg/push-tutrxopnrnvl
branch
from
37d48b9 to
c7f1868
Compare
obmarg
force-pushed
the
obmarg/push-tutrxopnrnvl
branch
from
c7f1868 to
da20eaf
Compare
✅ Deploy Preview for cynic-querygen-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
Support for generic parameters in QueryFragment (and elsewhere) was added in v3.0.0. In #708 a user asked how to do this, and I explained that it required two where bounds to be added by hand. I wasn't entirely happy with this: although it makes sense, it's annoyingly verbose and the
VariablesFieldsbound is particularly non-obvious.What effects does this change have?
This updates the QueryFragment impl to try and infer these bounds when generic parameters are declared on the struct and used on a field that we know is a composite type.
I've not bothered to do the same for scalar or enum fields at present. They also require bounds, but I think they're less useful and I don't want to put the effort in today. Can revisit this if any users complain.
Fixes #708
Fixes #709