-
Notifications
You must be signed in to change notification settings - Fork 36
Fixes #3427 NTR- epithelium of anorectum #3430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
b3200ac to
e203aeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
|
#gogoeditdiff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.
|
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -base file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsepithelium of anorectum
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsepithelium of anorectum
|
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
@matentzn should be good to rebase |
matentzn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on some previous approval by @gouttegd I also approve. Can be merged.
This PR modifies some logical definitions. See details below:Number of classes with modified logical definitions: 1 epithelium of anorectumNo changes in inferred subclasses. |
The idspace issue no longer relevant for this PR
matentzn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final tweak
Added a new term.
Needed for CL #2674